release_notes_generator/model/issue_record.py (1)

30-31: Good: Issue labels cached and PR labels merged into the same set (meets #149). Consider using get_labels() and optional normalization.

This implements the objective to merge PR and Issue labels. For SDK compatibility, mirror the get_labels() approach here as well.

Proposed adjustments:

-        self._labels = {label.name for label in self._issue.labels}
+        if hasattr(self._issue, "get_labels"):
+            self._labels = {label.name for label in self._issue.get_labels()}
+        else:
+            self._labels = {label.name for label in getattr(self._issue, "labels", [])}

-        self._labels.update({label.name for label in pull.labels})
+        if hasattr(pull, "get_labels"):
+            self._labels.update({label.name for label in pull.get_labels()})
+        else:
+            self._labels.update({label.name for label in getattr(pull, "labels", [])})

Optionally, normalize names (e.g., .lower()) to avoid case-sensitivity mismatches with chapter label keys. I can wire that if desired.

Also applies to: 162-162

tests/release_notes/test_release_notes_builder.py (1)

714-714: Tests poke private _labels; prefer updating the existing set rather than rebinding it

Directly assigning a new set replaces the object; using update() avoids surprises and reads clearer. Longer term, consider a small helper (e.g., rec.add_labels([...])) to avoid touching a private field from tests.

Apply:

-    rec._labels = {"bug", "breaking-changes"}
+    rec._labels.update({"bug", "breaking-changes"})

-    rec._labels = {"label1", "label2"}
+    rec._labels.update({"label1", "label2"})

-    rec._labels = {"bug", "enhancement"}
+    rec._labels.update({"bug", "enhancement"})

I can add a tiny test helper or a public method to seed labels if you want to avoid accessing _labels directly.

Also applies to: 733-733, 828-828

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

DEVELOPER.md (1)

34-36: Good: standardized venv + pip upgrade. Align the Black section too.
Black section still uses venv/ and lacks the pip upgrade. Unify to .venv for consistency.

Apply:

@@
-```shell
-python3 -m venv venv
-source venv/bin/activate
-pip install -r requirements.txt
-```
+```shell
+python3 -m venv .venv
+source .venv/bin/activate
+pip install --upgrade pip
+pip install -r requirements.txt
+```

release_notes_generator/record/record_factory.py (1)

59-60: Remove unused parameter skip_rec in nested function.
It’s never used; simplify signature and call.

-        def register_pull_request(pull: PullRequest, skip_rec: bool) -> None:
+        def register_pull_request(pull: PullRequest) -> None:
@@
-                register_pull_request(pull, skip_record)
+                register_pull_request(pull)

Also applies to: 109-109

tests/conftest.py (2)

438-441: Remove stray TODO in fixture name comment.
Avoid stale comments in tests.

-    rec = IssueRecord(issue=request.getfixturevalue("mock_issue_closed_i1_bug"))        # TODO - renamed from mock_issue_closed_i2_bug
+    rec = IssueRecord(issue=request.getfixturevalue("mock_issue_closed_i1_bug"))

---

136-141: Deduplicate label mock creation across fixtures.
Introduce a tiny helper to cut repetition.

Add once near the top of this file:

def make_labels(mocker, *names):
    labs = []
    for n in names:
        l = mocker.Mock()
        l.name = n
        labs.append(l)
    return labs

Then refactor calls, e.g.:

-    label1 = mocker.Mock(spec=MockLabel)
-    label1.name = "label1"
-    label2 = mocker.Mock(spec=MockLabel)
-    label2.name = "label2"
-    issue.get_labels.return_value = [label1, label2]
+    issue.get_labels.return_value = make_labels(mocker, "label1", "label2")

Also applies to: 154-158, 169-174, 201-206

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro